[1.00 Bug] Break » Forum Post by Naidrev

Its missing damage in the code:

Code: xml
 
    <SpellDef InternalName="Break">
        <DisplayName>Break</DisplayName>
        <Description>Normal attack that also removes all the Target's Defense for 3 actions.</Description>
        <IconFG>Ability_Break_Icon.png</IconFG>
        <CanStack>0</CanStack>
        <Cooldown>5</Cooldown>
        <SpellBookSortCategory>Unit</SpellBookSortCategory>
        <SpellBookSortSubCategory>UnitCurse</SpellBookSortSubCategory>
        <SpellType>Tactical</SpellType>
        <SpellClass>Offensive</SpellClass>
        <SpellSubClass>Debuff</SpellSubClass>
        <SpellTargetType>EnemyUnit</SpellTargetType>
        <HideInHiergamenon>1</HideInHiergamenon>
        <IsCastable>0</IsCastable>
        <CanBeDodged>1</CanBeDodged>
        <IsSpecialAbility>1</IsSpecialAbility>
        <UseWeaponRange>1</UseWeaponRange>
        <GameModifier>
            <ModType>Unit</ModType>
            <Attribute>AdjustUnitStat</Attribute>
            <StrVal>UnitStat_Defense_Pierce</StrVal>
            <DisplayName>Broken</DisplayName>
            <Duration>3</Duration>
            <Effect>E_Break_Particle</Effect>
            <Calculate InternalName="Calc" ValueOwner="TargetUnit">
                <Expression><![CDATA[[UnitStat_Defense_Pierce] * -1]]></Expression>
            </Calculate>
            <Calculate InternalName="Value">
                <Expression><![CDATA[[Calc]]]></Expression>
            </Calculate>
        </GameModifier>
        <AIData AIPersonality="AI_General">
            <AIPriority>5</AIPriority>
        <ValueCalcWrapper>
            <ValueType>IsTargetWorthy</ValueType>
            <Calculate InternalName="Calc" ValueOwner="TargetUnit">
                <Expression><![CDATA[[UnitStat_Defense_Pierce]]]></Expression>
            </Calculate>
            <Calculate InternalName="Value">
                <Expression><![CDATA[[Calc] > 5]]></Expression>
            </Calculate>
        </ValueCalcWrapper>
        </AIData>
        <HitSoundFX>Spell_Curse_01</HitSoundFX>
        <SpellDefEffect>
            <EffectName>T_Break_Particle</EffectName>
            <LocalPosition>0,50,0</LocalPosition>
            <EffectScale>1</EffectScale>
            <EffectDelay>0</EffectDelay>
            <SnapToTerrain>1</SnapToTerrain>
        </SpellDefEffect>
    </SpellDef>

This should fix it

https://www.dropbox.com/s/ovvo2zrloi1e8c1/breakfix.xml?m

Successfully updated karma reason!

Yeah, I fixed this back in the beta awhile back, but I don't think it was noticed.

Replicators - your fix will actually not do the correct damage, you only want to do this modifier.

        <GameModifier>
            <ModType>Unit</ModType>
            <Attribute>DefendableDamage</Attribute>
        </GameModifier>

The problem that arrises with the way you did it, is say versus a banshee, you will actually not do any damage with break fix, because the damage type you are doing is only piercing. It does take the combined effects of all the damage types, but only damage as if it were a club.

The above just specifies the attack is to be made and all damage is done according to their damage types.

Here is the fix that I had back in april.

https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/Abilities/breakfix.zip

Successfully updated karma reason!

Quoting parrottmath,

reply 2

Yeah, I fixed this back in the beta awhile back, but I don't think it was noticed.

Replicators - your fix will actually not do the correct damage, you only want to do this modifier.

        <GameModifier>
            <ModType>Unit</ModType>
            <Attribute>DefendableDamage</Attribute>
        </GameModifier>

The problem that arrises with the way you did it, is say versus a banshee, you will actually not do any damage with break fix, because the damage type you are doing is only piercing. It does take the combined effects of all the damage types, but only damage as if it were a club.

The above just specifies the attack is to be made and all damage is done according to their damage types.

Here is the fix that I had back in april.

https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/Abilities/breakfix.zip

Thank you, I did not know that.

Successfully updated karma reason!

Quoting Replicators,

reply 3

Quoting parrottmath, reply 2Yeah, I fixed this back in the beta awhile back, but I don't think it was noticed.

Replicators - your fix will actually not do the correct damage, you only want to do this modifier.

        <GameModifier>
            <ModType>Unit</ModType>
            <Attribute>DefendableDamage</Attribute>
        </GameModifier>

The problem that arrises with the way you did it, is say versus a banshee, you will actually not do any damage with break fix, because the damage type you are doing is only piercing. It does take the combined effects of all the damage types, but only damage as if it were a club.

The above just specifies the attack is to be made and all damage is done according to their damage types.

Here is the fix that I had back in april.

https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/Abilities/breakfix.zip

Thank you, I did not know that.

No problem.

Successfully updated karma reason!

Awesome, thanks guys. In your fix, does the damage apply after the armor is removed, or before? Seems like it should be after, as it is an end-of-the-line trait, and thus should be strong.

Successfully updated karma reason!