All +Attack is +Physical Attack, and most weapons are physical attack only.  Banshees are immune to Physical damage.  The only way the extra damage could damage Banshees would be if it was Fire or Cold damage - and that would mean you would be getting damage not resistable by armor against all undead, not just Banshees.

Such a niche weapon to begin with, and the scariest undead unit is immune to it!  That IS evil!

maybe just change it to give fire or electric damage against undead, no reason to add 'blessed' type of damage.

No need to do that...

https://dl.dropboxusercontent.com/u/75549875/Fallen%20Enchantress/LH%20Mods/BlessedWeapons/BlessedWeapons.zip

Why not just put that in the items folder.

It adds blessed damage to the game as well as ensuring that the damage doesn't change for other undead with piercing defense. Hence a simple change without changing the game too much. i.e. this weapon will now damage banshee's and will not be resisted by other undead creatures.

Namely defense stat is still pierce, but the resist stat has been completely changed.

Changing the weapon to fire, leads to burning corpse problem... immune 

changing the weapon to any other damage will also just ignore the natural defense the undead had before against the weapon which would lead to some rebalancing of the weapon damages, to ensure that it is a good change.

Would the resist stat stop the armor penetration. The ghost ability is not blocking the "damage" like armor, it is literally is resisting the damage.

Also, the game has 4 elements for each shard

toxic - earth shard

cold - water shard

fire - fire shard

lightening - air shard

What is the damage types for life and death shards? I think they missed these elements and only refer to them with the weapons.

It is easy to add blessed damage and dark damage. Seems missing.

I agree that it is total overkill to add a new damage type for just one weapon, but I figure this is a starting point to create a good base for a series of multiple weapons.

Armor penetration would clarify why it isn't effective against banshees. It can't hit them.

I think we just disagree with each other, and we're probably not going to reach a consensus. I think adding another damage type is way overboard and I'd rather remove the weapon completely. Meanwhile, +10 Fire damage against undead makes perfect sense to me. You obviously disagree, so let's leave it at that.

Parrotmath,

Just looked over your code.  Short, sweet, to the point.  Easily implemented.  I like it!

I'm guessing we wouldn't have too many weapons with this attribute in the game, so I don't see the blessed weapons file getting very long.  Hence, the 'full' weapons xml file can remain untouched, and this can exist alongside the existing files (via mods).  Unless the Stardock guys implement this in a patch of course, in which case there won't be much to change.  Nice job!

Looking at the code, I'm guessing that the Banshee would need to be classified as unit type 1 (hence modifying the core monster units file)?

Thanks,

The part you refer <vsUnitType> is a bool value. Suggesting that the game modifier is only applied when the specified target is of the type <StrVal2>

The banshee is undead, and so it uses that game modifier.

Actually that is the ONLY blessed weapon in the game. The other "blessed" weapons will be additions by other modders, and if someone would like to extend this mod to that situation, then they have a bit of work to properly implement the weapon damage blessed to the game. (I really did a patch job).

If someone were to follow this line of mod making and create a new weapon brands called blessed and such, they would really have to fully fix up the damage type I created here. This would include setting up appropriate damage defense and resistances to all the units in the game around this damage type. That is a large amount of work to undertake.

It would be far easier to say that the blessed hammer sends a holy fire upon the creatures of the undead and add fire damage when attack undead. This damage type is well established and fully implemented in the game. So, there would be little need to change anything along these lines.

I believe that is the point that heavenfall was making in the entire making a new weapon damage, which from the developers standpoint it is a good fix. My fix is really a patchwork and livable for a mod.

These two creatures are actually elementals. Thus, we already have weapons that do more damage to these types of creatures. I would like to see a dark magic damage to be brought into the game as well as a blessed magic. But I'd be happy with a generic "magic" damage. The magic from the light and death shards. Since they are one and the same shard just a corruption of one or the other. Then I would remove the blessed damage and add just this "magic" damage type.